ThePEG 2.1.3 fails to build with gcc8

[new]

Dear Herwig developers,

ThePEG version 2.1.3 fails to build with gcc8. See this build log: ​http://cdash.cern.ch/upload/f87142e466f4c7ec2b942920bbf7efa057c5ae78/thepeg-2.1.3-build.log
The error message is:

Error: The directory '/' does not exist.

It is emitted by setupThePEG tool when processing line 25 of ThePEGDefaults.in

cd /

Thanks,
Ivan for the GENSER team

[new]

Dear Herwig developers,

I confirm the reproducibility of this issue with gcc 8.1.1. Commenting the line 25 of ThePEGDefaults.in seems to do the trick, but the overall behaviour might then be changed.
The Herwig7 repository population seems to suffer the same issue.

Thanks,
Laurent

lforthom@…

[Peter Richardson]

So r54dd9b947cc1 fixes ThePEG, but it will now have to wait for 2.1.5, however there are build failures in a lot of the dependences, e.g. Gosam and VBFNLO, in FF.

[new]

@richardn: Many thanks for this fast reaction and correction!

Could you let me/us know where to pull this fix (https://herwig.hepforge.org/trac/browser?rev=54dd9b947cc1 does not seem to exist), or if a patch is generated somewhere to be used?

lforthom@…

[new]

Alternatively, before 2.1.5 is released, is there any patch I may apply on my test bench? (like what was done in #4)

[Peter Richardson]

Yes try the patch below

diff -r 94cc4d075a91 -r 54dd9b947cc1 Repository/BaseRepository.cc
--- a/Repository/BaseRepository.cc	Thu Jun 28 11:27:30 2018 +0200
+++ b/Repository/BaseRepository.cc	Thu Jun 28 16:48:52 2018 +0200
@@ -79,8 +79,7 @@
 }
 
 BaseRepository::DirectorySet & BaseRepository::directories() {
-  static char root[1][2] = {"/"};
-  static DirectorySet theDirectories(root, root+1);
+  static DirectorySet theDirectories = {"/"};
   return theDirectories;
 }

[new]

I confirm that this patch solves this issue.

Thanks,
Ivan for the GENSER team