#12 closed defect (fixed)
ThePEG 2.1.3 fails to build with gcc8
Reported by: | new | Owned by: | Peter Richardson |
---|---|---|---|
Priority: | major | Milestone: | Herwig 7.1.5 |
Version: | 7.1.3 | Keywords: | |
Cc: | ivan.razumov@… |
Description
Dear Herwig developers,
ThePEG version 2.1.3 fails to build with gcc8. See this build log: http://cdash.cern.ch/upload/f87142e466f4c7ec2b942920bbf7efa057c5ae78/thepeg-2.1.3-build.log
The error message is:
Error: The directory '/' does not exist.
It is emitted by setupThePEG tool when processing line 25 of ThePEGDefaults.in
cd /
Thanks,
Ivan for the GENSER team
Change History (8)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
Milestone: | Herwig 7.1.2 → Herwig 7.1.5 |
---|---|
Owner: | set to Peter Richardson |
Status: | new → assigned |
Version: | 7.1.1 → 7.1.3 |
comment:3 Changed 6 years ago by
Status: | assigned → accepted |
---|
comment:4 Changed 6 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
So r54dd9b947cc1 fixes ThePEG, but it will now have to wait for 2.1.5, however there are build failures in a lot of the dependences, e.g. Gosam and VBFNLO, in FF.
comment:5 Changed 6 years ago by
@richardn: Many thanks for this fast reaction and correction!
Could you let me/us know where to pull this fix (https://herwig.hepforge.org/trac/browser?rev=54dd9b947cc1 does not seem to exist), or if a patch is generated somewhere to be used?
comment:6 Changed 6 years ago by
Alternatively, before 2.1.5 is released, is there any patch I may apply on my test bench? (like what was done in #4)
comment:7 Changed 6 years ago by
Yes try the patch below
diff -r 94cc4d075a91 -r 54dd9b947cc1 Repository/BaseRepository.cc --- a/Repository/BaseRepository.cc Thu Jun 28 11:27:30 2018 +0200 +++ b/Repository/BaseRepository.cc Thu Jun 28 16:48:52 2018 +0200 @@ -79,8 +79,7 @@ } BaseRepository::DirectorySet & BaseRepository::directories() { - static char root[1][2] = {"/"}; - static DirectorySet theDirectories(root, root+1); + static DirectorySet theDirectories = {"/"}; return theDirectories; }
comment:8 Changed 6 years ago by
I confirm that this patch solves this issue.
Thanks,
Ivan for the GENSER team
Dear Herwig developers,
I confirm the reproducibility of this issue with
gcc 8.1.1
. Commenting the line 25 ofThePEGDefaults.in
seems to do the trick, but the overall behaviour might then be changed.The Herwig7 repository population seems to suffer the same issue.
Thanks,
Laurent
lforthom@…